Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

633 add long term housing categories #638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

633 add long term housing categories #638

wants to merge 2 commits into from

Conversation

jjfreund
Copy link
Contributor

@jjfreund jjfreund commented Sep 2, 2022

No description provided.

schroerbrian
schroerbrian requested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@schroerbrian schroerbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one error in the script where you're passing an incorrect child subcategory ID. Everything else is looking good.

db/sql/covid-long-term-housing.sql
(1100046, 1100049);

insert into category_relationships (parent_id, child_id) values
(1100046, 1100045);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1100045 here should be 1100050 so as to prevent the error of an incorrect child subcategory that we noticed in Staging/Prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schroerbrian schroerbrian schroerbrian requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@schroerbrian schroerbrian

@lgarofalo lgarofalo

@Akhtam Akhtam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjfreund @schroerbrian @lgarofalo @Akhtam