Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to bookmarks table #753

Merged

Conversation

katerina-kossler
Copy link
Contributor

@katerina-kossler katerina-kossler commented Oct 17, 2024

part of: #127

changes:

  • new field on bookmarks table (nullable) for backwards compat

notes:
will follow in future to set bookmark name to service name by default (and to any existing bookmarks)

questions:
not sure how we deploy db changes this year

Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the super late review, but this LGTM! Thanks for working on it!

@katerina-kossler katerina-kossler merged commit 80cd03b into master Nov 2, 2024
4 checks passed
@katerina-kossler katerina-kossler deleted the 127-bookmarks-should-have-customizable-names branch November 2, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants