-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic on pad #27
Comments
I think I've seen something similar when using a too big payload. |
@gbhrdt yes, just yesterday we tried to reduce our payloads and bug is gone. Today we try to increase payload again and the problem still not appears, moreover, our payloads now is even bigger then before, when the panic occurs, but the problem is gone and everything works fine. I not sure, maybe the problem was in header |
I also have this issue:
For now, I will defer/recover the panic in my code. |
This commit fixes a case where, with large notification payloads, pad would call make with a negative length, triggering a panic.
This commit fixes a case where, with large notification payloads, pad would call make with a negative length, triggering a panic.
In some cases the panic occurred when called
SendNotification
method.go version go1.12.1 linux/amd64
also tried
go version go1.12.5 linux/amd64
The text was updated successfully, but these errors were encountered: