-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better split #11
Better split #11
Conversation
I wonder if it would be better to make this a non-breaking change for now by adding the original methods but with a deprecated annotation instead unless I am missing a point here over "so it doesn't get changed later."? 🤔 |
Lists can change their length, so returning an array is better, because it shouldn't change. |
I see, is this ready to go or do you want to add more since I will be pushing it to the master branch to place it on its own version? |
It's ready to go |
Thanks for the PR, then! 🧇 |
Breaking change!
VelenCommand#getShortcuts() now returns a String[] so it doesn't get changed later.
The command parsing alg is reworked to be more readable.
The args get parsed more intelligent with respect to escapes and double qoutes.