Run MTR continuously in the background, use summary metrics instead #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, thx for the PR, when i have time i will review it. |
|
with which go version do you build the binary? |
|
1.11 in my case.
…On Fri, 28 Sep 2018, 16:21 Markus, ***@***.***> wrote:
with which go version do you build the binary?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAI-fp2EjZYI4rOIaaNPPsN9cTEkmfCJks5ufj6PgaJpZM4V5Usc>
.
|
|
sry for the late response , will merge it and tag it as new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running MTR synchronously on every request is slow, too slow for most timeouts in regular Prometheus setups.
Since the details of the targets are in config, rather than provided as part of a probe request, we can probe them continually in the background, and use counters and summaries to present the whole data over time instead.
This is a pretty big refactor that results in altered metric formats and names.