Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default timeout to 60s #30

Merged
merged 1 commit into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@
### Miscellaneous Chores

* release 1.0.0 ([c1407d2](https://www.github.com/ShipEngine/shipengine-python/commit/c1407d2de88182c75ba6dafff1ab30a3ed71efc6))

## 1.0.1

* increase default timeout from 5s to 60s
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "shipengine"
version = "1.0.0"
version = "1.0.1"
description = "The official Python library for ShipEngine API."
readme = "README.md"
authors = ["ShipEngine <support@shipengine.com>"]
Expand Down
2 changes: 1 addition & 1 deletion shipengine/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
"""ShipEngine SDK."""
__version__ = "1.0.0"
__version__ = "1.0.1"

import logging
from logging import NullHandler
Expand Down
2 changes: 1 addition & 1 deletion shipengine/shipengine_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class ShipEngineConfig:
DEFAULT_RETRIES: int = 1
"""Default number of retries the ShipEngineClient should make before returning an exception."""

DEFAULT_TIMEOUT: int = 5
DEFAULT_TIMEOUT: int = 60
"""Default timeout for the ShipEngineClient in seconds."""

def __init__(self, config: Dict[str, Any]) -> None:
Expand Down
2 changes: 1 addition & 1 deletion shipengine/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.0.0"
__version__ = "1.0.1"
2 changes: 1 addition & 1 deletion tests/test_shipengine_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def test_config_defaults(self) -> None:

assert config.retries == 1
assert config.page_size == 50
assert config.timeout == 5
assert config.timeout == 60
assert config.base_uri is BaseURL.SHIPENGINE_RPC_URL.value

def test_to_dict_method(self) -> None:
Expand Down
Loading