Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughThis pull request introduces a new Slider component to the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Pull request overview
Adds a new Slider component to the React UI library (built on @radix-ui/react-slider), along with Storybook documentation and package exports/changeset for release.
Changes:
- Introduce
Slidercomponent wrapper with styling hooks for track/range/thumb. - Add Storybook stories demonstrating default, range, controlled, vertical, and disabled variants.
- Export the new component from the component barrels and add a changeset for a minor release.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/react/ui/src/components/slider/slider.tsx | Implements Radix-based Slider wrapper and styling defaults. |
| libs/react/ui/src/components/slider/slider.stories.tsx | Adds Storybook coverage for common usage patterns. |
| libs/react/ui/src/components/slider/index.ts | Barrel export for the slider module. |
| libs/react/ui/src/components/index.ts | Re-exports Slider from the central components index. |
| .changeset/chilly-ears-fly.md | Declares a minor bump for @shipfox/react-ui to release Slider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@libs/react/ui/src/components/slider/slider.tsx`:
- Around line 54-58: The thumbs map in SliderPrimitive.Thumb uses the raw value
from _values as the React key which can produce duplicate keys (e.g., [50,50])
and break reconciliation; change the key to a stable unique identifier per thumb
such as combining the index with the value or using the array index (e.g.,
`${index}-${val}`) when mapping _values in the Slider component where
SliderPrimitive.Thumb is created, keeping className={cn(thumbDefaults,
thumbClassName)} intact.
Summary by CodeRabbit
New Features