Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make chip sold histogram display percentage instead of counts #1

Closed
ShiqiYang2022 opened this issue Jul 18, 2023 · 1 comment · Fixed by #2
Closed

Make chip sold histogram display percentage instead of counts #1

ShiqiYang2022 opened this issue Jul 18, 2023 · 1 comment · Fixed by #2
Assignees
@ShiqiYang2022

Comments

@ShiqiYang2022
Copy link
Owner

Step 3 for Practice task on RA Manual (Basic functionality).
@ShiqiYang2022 ShiqiYang2022 self-assigned this Jul 18, 2023
ShiqiYang2022 added a commit that referenced this issue Jul 18, 2023
@ShiqiYang2022
#1 Make chip sold histogram display percentage
8f532a3
ShiqiYang2022 added a commit that referenced this issue Jul 18, 2023
@ShiqiYang2022
#1 Revert the master branch
b447216
ShiqiYang2022 added a commit that referenced this issue Jul 18, 2023
@ShiqiYang2022
#1 Make chip sold histogram display percentage
a6cc669
@ShiqiYang2022 ShiqiYang2022 linked a pull request Jul 18, 2023 that will close this issue
PR for #1: Make chip sold histogram display percentage instead of counts #2
Merged
@ShiqiYang2022 ShiqiYang2022 mentioned this issue Jul 18, 2023
Merged
ShiqiYang2022 added a commit that referenced this issue Jul 18, 2023
@ShiqiYang2022
Merge pull request #2 from ShiqiYang2022/1-make-chip-sold-histogram-d…
72c5e9a 
…isplay-percentage-instead-of-counts

PR for #1: Make chip sold histogram display percentage instead of counts
@ShiqiYang2022
Copy link
Owner Author

ShiqiYang2022 commented Jul 18, 2023 •
edited
Loading

Summary + Deliverables

In this issue (#1) I modify the data/code/clean_data.py to make data/output/chips_sold.pdf display percentage instead of counts.

The main deliverable are the new chip sold histogram as well as the paper (page 4). This thread continued in the associated PR (#2). There's no follow-up issue for this modification.

Merged to master in 72c5e9a.
Final state of issue branch here.
Final state of issue subfolder here.

ShiqiYang2022 added a commit that referenced this issue Jul 26, 2023
@ShiqiYang2022
#1 Synchronize the Edits to Github Repository
0f85c03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShiqiYang2022 ShiqiYang2022

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR for #1: Make chip sold histogram display percentage instead of counts ShiqiYang2022/template
1 participant
@ShiqiYang2022