[Bug Fix] Restrict AST checker on Boolean Variable #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShishirPatil
pushed a commit
that referenced
this pull request
Mar 16, 2024
This PR rerun the checker as a result of 1. #252 2. #251 3. #256 4. https://huggingface.co/datasets/gorilla-llm/Berkeley-Function-Calling-Leaderboard
ShishirPatil
approved these changes
Mar 16, 2024
devanshamin
pushed a commit
to devanshamin/gorilla
that referenced
this pull request
Jul 9, 2024
This PR removes any AST checker answers that contain the string literals "True" and "False", thereby restricting the conditionals of the AST checker to strictly boolean value. Example: `[true, "true"] -> [true]` This PR will stack on top of ShishirPatil#252 Will this change the results of leaderboard? YES ShishirPatil#253 will updated the leaderboard with this fix.
aw632
pushed a commit
to vinaybagade/gorilla
that referenced
this pull request
Aug 22, 2024
This PR removes any AST checker answers that contain the string literals "True" and "False", thereby restricting the conditionals of the AST checker to strictly boolean value. Example: `[true, "true"] -> [true]` This PR will stack on top of ShishirPatil#252 Will this change the results of leaderboard? YES ShishirPatil#253 will updated the leaderboard with this fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes any AST checker answers that contain the string literals "True" and "False", thereby restricting the conditionals of the AST checker to strictly boolean value.
Example:
[true, "true"] -> [true]This PR will stack on top of #252
Will this change the results of leaderboard? YES
#253 will updated the leaderboard with this fix.