-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFCL April 8th Release #330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
CharlieJCJ
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ShishirPatil
approved these changes
Apr 11, 2024
devanshamin
pushed a commit
to devanshamin/gorilla
that referenced
this pull request
Jul 9, 2024
This PR is for the leaderboard April 8th release: 1. Fixed an oversight that was introduced in ShishirPatil#299. For function-calling (FC) models that cannot take `float` type in input, when the parameter type is a `float`, the evaluation procedure will convert that type to `number` in the model input and mention in the parameter description that `This is a float type value.`. An additional field `format: float` will also be included in the model input to make it clear about the type. 2. Update the model handler for Claude, Mistral, and OSS to better parse the model output. This is to patch the handler we released in ShishirPatil#299, as it sometimes fails to parse even though the model output is valid. This affects only the prompting models; the FC models are unaffected. This PR **DOES** change the leaderboard score. We will update the leaderboard website shortly, in a different PR. --------- Co-authored-by: Charlie Cheng-Jie Ji <charliechengjieji@berkeley.edu> Co-authored-by: Fanjia Yan <fanjiayan@berkeley.edu>
aw632
pushed a commit
to vinaybagade/gorilla
that referenced
this pull request
Aug 22, 2024
This PR is for the leaderboard April 8th release: 1. Fixed an oversight that was introduced in ShishirPatil#299. For function-calling (FC) models that cannot take `float` type in input, when the parameter type is a `float`, the evaluation procedure will convert that type to `number` in the model input and mention in the parameter description that `This is a float type value.`. An additional field `format: float` will also be included in the model input to make it clear about the type. 2. Update the model handler for Claude, Mistral, and OSS to better parse the model output. This is to patch the handler we released in ShishirPatil#299, as it sometimes fails to parse even though the model output is valid. This affects only the prompting models; the FC models are unaffected. This PR **DOES** change the leaderboard score. We will update the leaderboard website shortly, in a different PR. --------- Co-authored-by: Charlie Cheng-Jie Ji <charliechengjieji@berkeley.edu> Co-authored-by: Fanjia Yan <fanjiayan@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the leaderboard April 8th release:
float
type in input, when the parameter type is afloat
, the evaluation procedure will convert that type tonumber
in the model input and mention in the parameter description thatThis is a float type value.
. An additional fieldformat: float
will also be included in the model input to make it clear about the type.This PR DOES change the leaderboard score. We will update the leaderboard website shortly, in a different PR.
Co-authored-by: Charlie Cheng-Jie Ji charliechengjieji@berkeley.edu
Co-authored-by: Fanjia Yan fanjiayan@berkeley.edu