Fix Typos in Evaluation Script and System Prompt. Identify Errors in a Dataset #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zuxin666 , |
ShishirPatil
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Thanks for the PR, @zuxin666! Thanks for flagging it - addressing the bugs in the dataset, and the PR will be out soon!
devanshamin
pushed a commit
to devanshamin/gorilla
that referenced
this pull request
Jul 9, 2024
…a Dataset (ShishirPatil#335) This pull request addresses several minor issues found in the evaluation script and system prompts. I also found some errors in one of the dataset as outlined below. ### Changes: 1. Fixed a typo in the system prompt for chat models to ensure clarity in instructions provided to the model. 2. Evaluation Script Updates (`openfunctions_evaluation.py`): - Modified function parameters in `build_handler` to directly pass `temperature`, `top_p`, and `max_tokens` which enhances the readability and maintainability of the code. - Corrected the conditional checks and variable assignments to accurately reflect the intended logic for handling different test categories. ### Dataset Corrections: Two errors were identified in the dataset file `gorilla_openfunctions_v1_test_parallel_multiple_function.json`: 1. **Line 58**: We should change `"required": ["location", "star"]}}` to `"required": ["location", "stars"]}},` to match the expected function parameters. 2. **Line 171**: We should change `"required": ["player_name", "class"]` to `"required": ["player_name", "class_type"]` to align with the parameter names used in functions. I do not know how to update these files so just outline them here.
aw632
pushed a commit
to vinaybagade/gorilla
that referenced
this pull request
Aug 22, 2024
…a Dataset (ShishirPatil#335) This pull request addresses several minor issues found in the evaluation script and system prompts. I also found some errors in one of the dataset as outlined below. ### Changes: 1. Fixed a typo in the system prompt for chat models to ensure clarity in instructions provided to the model. 2. Evaluation Script Updates (`openfunctions_evaluation.py`): - Modified function parameters in `build_handler` to directly pass `temperature`, `top_p`, and `max_tokens` which enhances the readability and maintainability of the code. - Corrected the conditional checks and variable assignments to accurately reflect the intended logic for handling different test categories. ### Dataset Corrections: Two errors were identified in the dataset file `gorilla_openfunctions_v1_test_parallel_multiple_function.json`: 1. **Line 58**: We should change `"required": ["location", "star"]}}` to `"required": ["location", "stars"]}},` to match the expected function parameters. 2. **Line 171**: We should change `"required": ["player_name", "class"]` to `"required": ["player_name", "class_type"]` to align with the parameter names used in functions. I do not know how to update these files so just outline them here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several minor issues found in the evaluation script and system prompts.
I also found some errors in one of the dataset as outlined below.
Changes:
openfunctions_evaluation.py):build_handlerto directly passtemperature,top_p, andmax_tokenswhich enhances the readability and maintainability of the code.Dataset Corrections:
Two errors were identified in the dataset file
gorilla_openfunctions_v1_test_parallel_multiple_function.json:"required": ["location", "star"]}}to"required": ["location", "stars"]}},to match the expected function parameters."required": ["player_name", "class"]to"required": ["player_name", "class_type"]to align with the parameter names used in functions.I do not know how to update these files so just outline them here.