Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raft.py with default p to match paper #353

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

ShishirPatil
Copy link
Owner

@ShishirPatil ShishirPatil commented Apr 14, 2024

Change p which dictates the fraction of dataset with golden documents in them (vs) no golden documents.

So, p = 0.8 means, for 80% of the train data set, A* = Q + D* + D1 .. Dn and for 20% of the train data set A* = Q + D1 .. Dn where D* are/is the golden document with the answer A*.

Close #325

Change `p` which dictates the fraction of dataset with golden documents in them (vs) no golden documents. 

So, p = 0.8 means, for 80% of the train data set, `A* = Q + D* + D1 .. Dn` and for 20% of the train data set `A* = Q + D1 .. Dn` where `D*` are/is the golden document with the answer `A*`.
Copy link
Collaborator

@tianjunz tianjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShishirPatil ShishirPatil merged commit 7032c0e into main Apr 14, 2024
@ShishirPatil ShishirPatil deleted the RAFT-default-p branch April 14, 2024 03:46
devanshamin pushed a commit to devanshamin/gorilla that referenced this pull request Jul 9, 2024
Change `p` which dictates the fraction of dataset with golden documents
in them (vs) no golden documents.

So, p = 0.8 means, for 80% of the train data set, `A* = Q + D* + D1 ..
Dn` and for 20% of the train data set `A* = Q + D1 .. Dn` where `D*`
are/is the golden document with the answer `A*`.

Close ShishirPatil#325
aw632 pushed a commit to vinaybagade/gorilla that referenced this pull request Aug 22, 2024
Change `p` which dictates the fraction of dataset with golden documents
in them (vs) no golden documents.

So, p = 0.8 means, for 80% of the train data set, `A* = Q + D* + D1 ..
Dn` and for 20% of the train data set `A* = Q + D1 .. Dn` where `D*`
are/is the golden document with the answer `A*`.

Close ShishirPatil#325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperparameter of the number of distractor documents and the ratio of golden documents in training RAFT
2 participants