Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Sanity check is now optional #496

Merged
merged 14 commits into from
Jul 7, 2024
Merged

[BFCL] Sanity check is now optional #496

merged 14 commits into from
Jul 7, 2024

Conversation

ShishirPatil
Copy link
Owner

@ShishirPatil ShishirPatil commented Jul 2, 2024

  1. Sanity check is now optional. Further if the checks fail, we catch that and then continue the evaluation. That way if an API is down, it doesn't hinder other evaluations especially AST evaluations.
  2. Update README.

Close #486

This PR does NOT update the Leaderboard values.

Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@ShishirPatil ShishirPatil merged commit 506f73f into main Jul 7, 2024
@ShishirPatil ShishirPatil deleted the dev/shishirpatil branch July 7, 2024 21:55
devanshamin added a commit to devanshamin/gorilla that referenced this pull request Jul 8, 2024
devanshamin added a commit to devanshamin/gorilla that referenced this pull request Jul 8, 2024
devanshamin pushed a commit to devanshamin/gorilla that referenced this pull request Jul 9, 2024
1. Sanity check is now optional. Further if the checks fail, we catch
that and then continue the evaluation. That way if an API is down, it
doesn't hinder other evaluations especially AST evaluations.
2. Update README.

Close ShishirPatil#486 

This PR does NOT update the Leaderboard values.

---------

Co-authored-by: Huanzhi Mao <huanzhimao@gmail.com>
aw632 pushed a commit to vinaybagade/gorilla that referenced this pull request Aug 22, 2024
1. Sanity check is now optional. Further if the checks fail, we catch
that and then continue the evaluation. That way if an API is down, it
doesn't hinder other evaluations especially AST evaluations.
2. Update README.

Close ShishirPatil#486 

This PR does NOT update the Leaderboard values.

---------

Co-authored-by: Huanzhi Mao <huanzhimao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BFCL] Sanity check should be optional and by default off
2 participants