Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Improved tree-sitter java, javascript installation #505

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

CharlieJCJ
Copy link
Collaborator

@CharlieJCJ CharlieJCJ commented Jul 6, 2024

Purpose:

Changes:

  • remove steps of cloning repo, symlinks, builds
  • add tree-sitter-java and tree-sitter-javascript in requirements.txt with pip install

Test:

  • Tested end-to-end BFCL generation and checked on gorilla-openfunctions-v2 and llama3-70B.

…s of cloning repo, simlinks; included in requirements.txt with pip install
@CharlieJCJ CharlieJCJ changed the title Improved tree-sitter java, javascript installation [BFCL] Improved tree-sitter java, javascript installation Jul 6, 2024
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Good to go.

Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @CharlieJCJ

@ShishirPatil ShishirPatil merged commit 5ac9062 into ShishirPatil:main Jul 7, 2024
devanshamin pushed a commit to devanshamin/gorilla that referenced this pull request Jul 9, 2024
…il#505)

**Purpose**:
- One step addressing ShishirPatil#501 

**Changes**:
- remove steps of cloning repo, symlinks, builds
- add `tree-sitter-java` and `tree-sitter-javascript` in
requirements.txt with pip install

**Test**:
- Tested end-to-end BFCL generation and checked on
gorilla-openfunctions-v2 and llama3-70B.

Co-authored-by: Shishir Patil <30296397+ShishirPatil@users.noreply.github.com>
aw632 pushed a commit to vinaybagade/gorilla that referenced this pull request Aug 22, 2024
…il#505)

**Purpose**:
- One step addressing ShishirPatil#501 

**Changes**:
- remove steps of cloning repo, symlinks, builds
- add `tree-sitter-java` and `tree-sitter-javascript` in
requirements.txt with pip install

**Test**:
- Tested end-to-end BFCL generation and checked on
gorilla-openfunctions-v2 and llama3-70B.

Co-authored-by: Shishir Patil <30296397+ShishirPatil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants