fix line return #531
Merged
fix line return #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuanzhiMao
approved these changes
Jul 18, 2024
|
Hi @HuanzhiMao , I don't have permission to merge. Feel free to merge it for me when you get a chance. |
|
Thanks for the catch @fantasist and welcome! |
aw632
pushed a commit
to vinaybagade/gorilla
that referenced
this pull request
Aug 22, 2024
`len(data)` is the size of json object parsed from a line, which does not represent the count of lines in the source file. This incorrectly squashes most contents of the input file to the second line of the output file. --------- Co-authored-by: Yunfan Zhong <alanwake@in.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
len(data)is the size of json object parsed from a line, which does not represent the count of lines in the source file. This incorrectly squashes most contents of the input file to the second line of the output file.