Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BFCL] Dataset Question Fix for Executable Parallel Category #568

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

HuanzhiMao
Copy link
Collaborator

@HuanzhiMao HuanzhiMao commented Aug 6, 2024

This PR fixes #541.

Thanks to @XuHwang for pointing this out. Some prompts in the executable_parallel_function category are misleading. They are formatted as:

First let's start by xxxx. Once we have that xxxx, then xxxx. 
One at a time?

This would suggest the model generates one function calling at once, resulting in multi-turn functional calling. So we rephrased the prompts to make it clear.

The possible answers are unchanged.

We will update the leaderboard shortly, in a different PR.

Copy link
Collaborator

@Fanjia-Yan Fanjia-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@CharlieJCJ CharlieJCJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@ShishirPatil ShishirPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out @XuHwang

@ShishirPatil ShishirPatil merged commit 4a64db3 into ShishirPatil:main Aug 7, 2024
@HuanzhiMao HuanzhiMao deleted the exec_parallel_fix branch August 7, 2024 07:54
ShishirPatil pushed a commit that referenced this pull request Aug 15, 2024
 (Dataset Fix & New Model) (#572)

This PR updates the leaderboard to reflect the changes in score due to
the following PR merge:

- #557 
- #568 

and the addition of the following models:

- #569 
- #570 
- #573
aw632 pushed a commit to vinaybagade/gorilla that referenced this pull request Aug 22, 2024
…Patil#568)

This PR fixes ShishirPatil#541.

Thanks to @XuHwang for pointing this out. Some prompts in the
`executable_parallel_function` category are misleading. They are
formatted as:
```
First let's start by xxxx. Once we have that xxxx, then xxxx. 
One at a time?
```
This would suggest the model generates one function calling at once,
resulting in multi-turn functional calling. So we rephrased the prompts
to make it clear.

The possible answers are unchanged. 

We will update the leaderboard shortly, in a different PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BFCL] Incorrect ground truth
4 participants