Fix/merge commit #605 and #604 #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 30 chunks, if the process fails at chunk 29 (0-indexed), then checkpoint saves 30//15*15 = 15 instead of 30 Moreover, no need to save checkpoint state for every chunk, it's only need when the ds is actually saved and makes the code easier to understand.
because different systems have different expectations.
To clarify that this is the ground truth gold answer as opposed to the answer generated by the fine tuned model
- makes collecting checkpoints less expensive - makes deleting checkpoints a single line call
- Threads can stop early when asked through shared Event - `--qa-threshold` param to configure when to stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #605 and #604 had conflicting requirements.txt. This should fix it.