Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #614: [BFCL] ModuleNotFoundError after commit 70d6722 #615

Merged

Conversation

kobe0938
Copy link
Contributor

Bug fix of #614

This pull request resolves the ModuleNotFoundError reported in issue #614 by updating the import paths affected by the directory restructuring in commit 70d6722. The adjustments ensure that the LLM inference functionality works as expected.

Changes:

  • oss_handler.py and gorilla_handler.py import paths updated to include the new bfcl directory prefix.

Testing:
Run the following command to verify that the issue has been resolved:
python openfunctions_evaluation.py --model gorilla-openfunctions-v2 --test-category multiple --num-threads 1

@kobe0938 kobe0938 force-pushed the bugfix/fix-incorrect-import-path branch from f7a48dd to 63532ed Compare August 29, 2024 00:27
Copy link
Collaborator

@HuanzhiMao HuanzhiMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kobe0938!
LGTM

@HuanzhiMao HuanzhiMao merged commit b979102 into ShishirPatil:main Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BFCL] ModuleNotFoundError after Restructuring in Commit 70d6722: Incorrect Import Paths
2 participants