Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BFCL] Fix Decoding Issue in Nvidia Handler #623

Merged
merged 4 commits into from
Sep 9, 2024
Merged

[BFCL] Fix Decoding Issue in Nvidia Handler #623

merged 4 commits into from
Sep 9, 2024

Conversation

HuanzhiMao
Copy link
Collaborator

In this PR:

  1. Fix decoding issue in the NvidiaHandler. An unnecessary whitespace in the decode method caused many model responses fail to get decoded (should be [ instead of [ , and ] instead of ]).
  2. Remove duplicate ArcticHandler class. It is the exact same as NvidiaHandler, so we just let snowflake/arctic use NvidiaHandler instead.

This will affect the leaderboard score for nvidia/nemotron-4-340b-instruct and snowflake/arctic. We will update it shortly.

Credit to @mattf for pointing these out.

Co-authored-by: Matthew Farrellee mfarrellee@nvidia.com

@HuanzhiMao HuanzhiMao added the BFCL-General General BFCL Issue label Sep 4, 2024
Fanjia-Yan
Fanjia-Yan approved these changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@Fanjia-Yan Fanjia-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShishirPatil ShishirPatil merged commit 8ba9479 into ShishirPatil:main Sep 9, 2024
@HuanzhiMao HuanzhiMao deleted the fix_nvidia_handler branch September 9, 2024 20:19
@HuanzhiMao HuanzhiMao mentioned this pull request Sep 14, 2024
Merged
ShishirPatil pushed a commit that referenced this pull request Sep 15, 2024
@HuanzhiMao @CharlieJCJ
[BFCL] Leaderboard Update, in sync with #600, #608, #616, #623, #626, #…
2bc9c4a 
…627, #635, and #638. (#639)

This PR updates the leaderboard to reflect the change in score due to
the following PR merge:

1. #608
2. #600
3. #616 
4. #623
5. #626
6. #627
7. #635 
8. #638

---------

Co-authored-by: Charlie Cheng-Jie Ji <charliechengjieji@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShishirPatil ShishirPatil ShishirPatil approved these changes

@Fanjia-Yan Fanjia-Yan Fanjia-Yan approved these changes

Assignees
No one assigned
Labels
BFCL-General General BFCL Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuanzhiMao @ShishirPatil @Fanjia-Yan