[BFCL] Multi Turn Pipeline Robustness Patch #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fanjia-Yan
approved these changes
Oct 29, 2024
Merged
ShishirPatil
pushed a commit
that referenced
this pull request
Oct 31, 2024
This PR fixes an issue introduced in #724. We need to preserve the original `func_call` to avoid errors during evaluation. `func_call` should be like `xxxx_instance.cd(folder='document')` so that when `eval(func_call)`, the `cd` method is invoked. Without the patch, `func_call` would become `cd` and thus resulting in variable not found error.
VishnuSuresh27
pushed a commit
to VishnuSuresh27/gorilla
that referenced
this pull request
Nov 11, 2024
This PR adds checks to prevent unsafe function calls from being run and potentially breaking the evaluation pipeline. 1. In GorillaFileSytem, the `xargs` method is removed. This will not affect the dataset entries, and that function is not used in any entries. 2. In `execute_multi_turn_func_call`, an input filter has been implemented to prevent the execution of unsafe function calls like `kill`, `exit`, `remove`, etc. --------- Co-authored-by: Shishir Patil <30296397+ShishirPatil@users.noreply.github.com>
VishnuSuresh27
pushed a commit
to VishnuSuresh27/gorilla
that referenced
this pull request
Nov 11, 2024
This PR fixes an issue introduced in ShishirPatil#724. We need to preserve the original `func_call` to avoid errors during evaluation. `func_call` should be like `xxxx_instance.cd(folder='document')` so that when `eval(func_call)`, the `cd` method is invoked. Without the patch, `func_call` would become `cd` and thus resulting in variable not found error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks to prevent unsafe function calls from being run and potentially breaking the evaluation pipeline.
xargsmethod is removed. This will not affect the dataset entries, and that function is not used in any entries.execute_multi_turn_func_call, an input filter has been implemented to prevent the execution of unsafe function calls likekill,exit,remove, etc.