Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Calculator #59

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

matricali
Copy link

🚧 WORK IN PROGRESS 🚧

PR related to #54

Calculator

  • Addition
  • Substraction
  • Division
  • Multiplication
  • Memory operations (Set, Restore, Clear, Addition)
  • Square root

@vercel
Copy link

vercel bot commented Apr 15, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://winxp-git-fork-matricali-feature-calculator.shizukuichi.now.sh

@VocalFan
Copy link
Contributor

Screenshot 2019-04-15 at 2 41 51 PM
Seems legit.

@panmona
Copy link

panmona commented Apr 15, 2019

Nice first version!

Not sure if you're aware of this but it would be great if the buttons were raised a bit and that you can see them being pressed down when you click on them.
Also M+ should be aligned with the 0 button.
What I mean is shown here:
image

@VocalFan
Copy link
Contributor

Also Backspace is clipping off button on a small screen.

src/WinXP/apps/Calculator/index.js Outdated Show resolved Hide resolved
FIX typo (thanks @ghostslayer989)

Co-Authored-By: ghostslayer989 <45863583+ghostslayer989@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants