Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift Restriction on Fable and Feliz version #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

panmona
Copy link

@panmona panmona commented Feb 6, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (fake build or .\build.cmd) on local branch was successful
    • For some reason the build wants to use Mono on my local machine, which makes it fail. Not so sure why this happens.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There's an upper restriction on the Feliz and Fable version:
image

What is the new behavior?

This PR removes this upper restriction. Currently no changes are needed to make it possible to use this library with React 18 aswell.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant