Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed erroneous "$" in TMDB API Request #79

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

fearnlj01
Copy link
Contributor

The pains of working in C# and JS 😔

The pains of working in C# and JS 😔
@fearnlj01
Copy link
Contributor Author

I'll note that this PR won't fully fix my unreported issue... My instance of Shoko Server is apparently not able to retreive the TMDB crew/cast in a large number of instances, which in turn causes an (unhandled) exception, returning a 500 response and blocking Shokofin from doing it's thing.

(I'm redownloading TMDB info and will follow up if I continue to have issues once that completes)

Copy link
Member

@revam revam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@revam revam merged commit a794815 into ShokoAnime:dev Nov 17, 2024
@fearnlj01 fearnlj01 deleted the fix-api-typo branch November 21, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants