Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

change featured collections on index.liquid #124

Merged
merged 1 commit into from
Jun 19, 2014
Merged

change featured collections on index.liquid #124

merged 1 commit into from
Jun 19, 2014

Conversation

jholl
Copy link

@jholl jholl commented Jun 19, 2014

  • update comments to show five collections instead of three (old ref)
  • offset index operator > in case 6 collections before 'frontpage collection'
  • move index counter inside unless 'frontpage collection' to work with offset

- update comments to show five collections instead of three (old ref)
- offset index operator > in case 6 collections before 'frontpage collection'
- move index counter inside unless 'frontpage collection' to work with offset
@jholl
Copy link
Author

jholl commented Jun 19, 2014

the forloop for collection in collections is looping through collections in alphabetical order - therefore if six collections alpha before 'frontpage' then they will all show up; however we want only five to showup. In current demo store, believe this 'works' because there are five collections 'collection-1, collection-2 ... etc' that show up before 'frontpage' thus frontpage is the sixth collection in the list. Add 'collection-6' to the demo store and things should be 'broken'

@cshold cshold merged commit 0fe3ab2 into Shopify:master Jun 19, 2014
@cshold
Copy link
Contributor

cshold commented Jun 19, 2014

Good catch on this, and thanks for the PR. Tested and merged it in.

@jholl jholl deleted the patch-7 branch August 23, 2014 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants