This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Moved product JS to external file (mostly) #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
product.liquid
JS intoshop.js.liquid
shop.js.liquid
cache'd selectors, the remaining JS is moved totheme.liquid
so it runs aftertimber.init
is fired.Update:
timber.init
(therefor can be moved back toproduct.liquid
)cc/ @stevebosworth @mpiotrowicz