This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
remove Ajaxify regex #324
Merged
remove Ajaxify regex #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace buggy regex (invalid if product name contains a “-“) with data directly from the API response
|
Looks great. Thoughts on making sure "Default Title" is never shown on the variant title? This only happens if there are no variant names. |
hide default variant
|
That can lead to an empty tag in the cart template. In my store, I check for a default title and use a conditional in the handlebars template. |
|
Love it, great approach. Mergin' |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace buggy regex (invalid if product name contains a “-“) with data directly from the API response