-
Notifications
You must be signed in to change notification settings - Fork 492
Reudced selector specificity. New form and list defaults. #348
Conversation
input[type="number"], | ||
input[type="tel"], | ||
input[type="url"], | ||
input, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we should be this opinionated about form input styling by default. There was a good discussion about this in FED slack earlier today, but by styling form elements directly, if you want to create any variation within the theme for those elements, you'd need to undo all of these styles in that variant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does timber as a base even need form styles out of the box? Presumably these are overwritten by each theme anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... i still think this is too opinionated as a default? How would these be overwritten if a variant on an input was required? @cshold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a step to reduce selector specificity, which I think it accomplishes. It's not perfect, so we'll revisit the reset vs base styles in another PR shortly.
Reudced selector specificity. New form and list defaults.
Form selectors:
input[type="XXXX"]
means a single class won't override it.input
, we can style all inputs the same and override them with classes whe needed.radio
andcheckbox
styles are overwritten on the element levelinput[type="image"]
is overwritten on the element-level.additional_checkout_buttons
(PayPal especially_Lists
Updated templates:
ul
elements to includeno-bullets
class@stevebosworth @mpiotrowicz