-
Notifications
You must be signed in to change notification settings - Fork 492
Conversation
This certainly gives you more control over what prefixes will be used, but puts the onus on the dev to know which to supply each time the mixin is used. While they're not all necessary, I'd argue a blanket prefix function eases the dev and reduces chances that any required are missed. @stevebosworth @mpiotrowicz what do you think? |
I agree with @cshold. I think this would ultimately create more problems and complexity since the onus is on the developer to know which prefixes are required which is something that can change as browsers are updated. If the unnecessary prefixes are causing problems, I would recommend using a prefixer as part of a build process. |
Having a "prefix-all-the-things" mixin is simple and straightforward solution but not particularly elegant nowadays since the need to prefix anything is quickly disappearing. Almost nothing requires Using the wrapper pattern like we're doing here for |
You make a good point. How about we go with your suggestions, and add back in the backface mixin. On animation heavy sites it's great to just use |
Assuming |
Hey @cshold, is there anything more you'd like me to do to make this shippable? Let me know 👍 |
This looks great. Last thing I'd ask is for a quick link to the boubon source or docs in the comment. Then let's 🚢 |
Alright, I also updated the comment block to match the other ones. I think we're good to go! |
Looks great. I'll add this to the next release and update the docs accordingly. Cheers |
transition
,linear-gradient
,transform
, andbox-sizing
prefix
mixin withprefixer
inspired by Bourbon's prefixer. Encourages only using necessary prefixes.Test store: http://timber-dev.myshopify.com/