-
Notifications
You must be signed in to change notification settings - Fork 492
Conversation
Only defined for IE9+ | ||
==============================================================================*/ | ||
html:not(.lt-ie9) { | ||
.table--responsive { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are more IE9 + browsers than not, why position this as the exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If responsive tables are default, we'd have to undo all the styles for older IE. This covers all modern browsers since they won't match the :not
selector with the least styles defined. Open to suggestions for sure though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but since they're under a media query these styles wouldn't apply to oldIE anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With respond.js all media queries are processed too. First time it wasn't really wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so then why not add the responsive behavior to oldIE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I thought it would be totally busted in IE8, even with respond.js. This demo proves that wrong. @stevebosworth, can you get a demo shop up with this PR and remove the :not(.lt-ie9)
- it may work perfectly already :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great lesson in never assuming anything :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! It totally works on ie8 without the conditional
just waiting on translated strings for i18n but good to go after that? |
Yup, looks good on my end |
switch cart over to table layout
Just looking at the source on this page <span class="visually-hidden">Regular price</span>
<span id="ProductPrice" class="h2" itemprop="price">$257.40</span>
<span class="visually-hidden">Sale price</span>
<p id="ComparePrice">Compare at $365.99</p> The visually hidden "Sale price" is listed with the higher "Compare at" price. Maybe the terminology is different in different countries, or maybe I misunderstand. But normally from my experience the sale price should be cheaper. |
@suture I think you are right. It should be something like "Original price" |
@stevebosworth you able to make a quick update for that? |
@cshold @mpiotrowicz
Switched the cart over to a table layout for improved a11y