Better handling for onboarding in collections

[jonathanmoore]

Currently Timber displays the onboarding message when collection.handle == 'all' returns no products. There is one case where /collection/all does contain products, but if you use non-existent tags on /collection/all it shows onboarding rather than a "no products found" message.

I know it is a pretty rare edge case, but it came up during a Shopify theme review for submission.

[cshold]

Fair enough. Never thought about that case but it does seem like it could have unintended consequences. Thanks for the PR.

[suture]

With this approach if you delete all collections and hide all products. Onboarding won't display if some of your hidden products have tags.

Instead it displays "Sorry, there are no products in this collection", which doesn't seem correct if you have no collections.

The Brooklyn theme uses this approach, and shows on boarding in the above described scenario.

{% if shop.products_count == 0 %}