This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Using the settings.logo_max_width value in styles #461
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. One adjustment that we've been using lately is to not require the |
|
Yahh You right... I have updated the files :) |
| @@ -113,6 +113,9 @@ $colorNavText: #333; | |||
| $colorFooterBg: {{ settings.color_footer_bg }}; | |||
| $colorFooterText: {{ settings.color_footer_text }}; | |||
|
|
|||
| // Logo max width | |||
| $logoMaxWidth: {{ settings.logo_max_width | default: '450' }}px; | |||
There was a problem hiding this comment.
I personally do this in the theme, so even for people including the px, it does not break:
{{ settings.logo_max_width | default: '450' | remove: 'px' }}px;
There was a problem hiding this comment.
That is smart! @montalvomiguelo are you able to adjust that line and we can merge it in.
cshold
added a commit
that referenced
this pull request
Sep 17, 2015
Using the settings.logo_max_width value in styles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added that value in the stylesheet in order to get this setting working.
Address #460