Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Updated icon set #538

Merged
merged 1 commit into from
May 20, 2016
Merged

Updated icon set #538

merged 1 commit into from
May 20, 2016

Conversation

cshold
Copy link
Contributor

@cshold cshold commented May 17, 2016

New payment icons

  • Dogecoin
  • Dwolla
  • Forbrugsforeningen
  • Laser
  • Litecoin
  • Solo
  • Switch
  • Removed Google Wallet
    image

By looping through all shop.enabled_payment_types in the footer, we're suseptible to showing new payment types before an icon is added to Timber's icon set. I've added in a whitelist to only hold the ones we have icons for.

Other new icons

  • Instagram's new logo
  • Updated Google+ logo (now named google-plus, instead of google)

image

@stevebosworth @Lisa-Villeneuve @carolineschnapp

@cshold cshold self-assigned this May 17, 2016
@Lisa-Vanderschuit
Copy link

Looks good to me on my test shop. The whitelist idea is great 👍

@suture
Copy link

suture commented May 18, 2016

@cshold
Copy link
Contributor Author

cshold commented May 18, 2016

Yup, it looks like those are no longer active yet still show up as available methods in Shopify source. I'll ask around about getting the legacy payment methods fully removed, then update the icon set again once they are.

@matcaissy
Copy link
Contributor

@cshold
Copy link
Contributor Author

cshold commented May 20, 2016

For those that couldn't see the private link above, it was about icon alignment — specifically with Instagram and Google+. I went through and updated every icon we have to be better aligned and sized.

image

@cshold cshold merged commit 28831f9 into master May 20, 2016
@cshold cshold deleted the new-icons branch May 20, 2016 14:49
@cshold cshold mentioned this pull request May 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants