This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Show errors in customer address forms #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {% form 'customer_address', customer.new_address %} | ||
|
|
||
| {% form 'customer_address', customer.new_address %} | ||
| <div id="AddAddress" class="form-vertical" {% unless form.errors %}style="display:none;"{% endunless %}> |
There was a problem hiding this comment.
Hm, with the form wrapped around this we'll always have the element visible on the page (though empty). I can't think of another way (without JS) so as long as this doesn't effect the layout, 👍
cshold
force-pushed
the
fix-customer-addresses
branch
from
cf4c07e
to
3fecdcc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopify's liquid checklist requires that errors are outputted properly on the
customer/addresses.liquidfile. This PR makes Timber comply with Shopify's theme requirements.@cshold for review