Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Wait for images to load before resizing cart drawer #62

Merged
merged 3 commits into from
May 5, 2014

Conversation

cshold
Copy link
Contributor

@cshold cshold commented May 5, 2014

  • Used to rely on a timeout to hope all cart images had loaded before setting the drawer's height. Now using .load on each image in the cart and setting once all have loaded.
  • product ID was wrong on /cart template. This fixes that and adds animation to removing an item from the ajax cart

cshold added a commit that referenced this pull request May 5, 2014
Wait for images to load before resizing cart drawer and fix quantity/remove animations in ajax cart
@cshold cshold merged commit dab87e7 into master May 5, 2014
@cshold cshold deleted the ajax-cart-image-load branch May 15, 2014 17:52
cimocimocimo pushed a commit to cimocimocimo/Theia-Shopify-Theme that referenced this pull request Nov 25, 2014
Wait for images to load before resizing cart drawer and fix quantity/remove animations in ajax cart
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant