This repository has been archived by the owner on Aug 30, 2018. It is now read-only.
Restructured modal close button so modal now scrolls if too tall #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cshold
added a commit
that referenced
this pull request
May 21, 2014
Restructured modal close button so modal now scrolls if too tall
cimocimocimo
pushed a commit
to cimocimocimo/Theia-Shopify-Theme
that referenced
this pull request
Nov 25, 2014
Restructured modal close button so modal now scrolls if too tall
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal wasn't able to scroll if it was taller than the window because of
overflow: visibleon#ajaxifyModal.is-visible- which was enabled to show the close button. Now the button lives on its own and is positioned with JS.