Icons and Modernizer Adjustments

[cshold]

• Moving Modernizer in to its own file and included separately
• Standardized icon font approach to be css-centric
  • Text fallback when font-face not supported
• Limit social links to Facebook, Twitter, Pinterest (more can be added easily)
• Simplified payment icon generation

[cshold]

@tobi @mpiotrowicz Moved to a much simpler icon approach with text fallback when font-face isn't supported.

[tobi]

we should just make type.name work instead of relying on magical replace. @markdunkley know someone who could do that?

[markdunkley]

@gauravmc thoughts? {{ type | name }}

[gauravmc]

@tobi making {{ type.name }} work will mean making some drop instead of simple type string right?

It'll be simple enough to add a filter as @markdunkley's suggesting. We can add a humanize filter that replaces underscores with spaces. @cshold is such operation common?

[cshold]

I wouldn't say common, though I'm also not very familiar with similar languages. humanize has a nice ring to it though.

[tobi]

I like humanize as a filter.

-- Tobi
CEO Shopify

(mobile)

On Jun 3, 2014, at 7:05 PM, Carson Shold notifications@github.com wrote:

In snippets/footer.liquid:

•    {% if type == "interac" %}<li>I</li>{% endif %}
  

•    {% if type == "visa" %}<li>V</li>{% endif %}
  

•    {% if type == "master" %}<li>M</li>{% endif %}
  

•    {% if type == "discover" %}<li>D</li>{% endif %}
  

•    {% if type == "dk" %}<li>d</li>{% endif %}
  

•    {% if type == "american_express" %}<li>A</li>{% endif %}
  

•    {% if type == "google" %}<li>G</li>{% endif %}
  

•    {% if type == "paypal" %}<li>P</li>{% endif %}
  

•    {% if type == "jcb" %}<li>J</li>{% endif %}
  

•    {% if type == "cirrus" %}<li>C</li>{% endif %}
  

•    {% if type == "stripe" %}<li>S</li>{% endif %}
  

•    {% if type == "bitcoin" %}<li>B</li>{% endif %}
  

•    <li>
  

•      <span class="icon-fallback-text">
  

•        <span class="icon icon-{{type}}" aria-hidden="true"></span>
  

•        <span class="fallback-text">{{type | replace: '_',' '}}</span>
  

  I wouldn't say common, though I'm also not very familiar with similar languages. humanize has a nice ring to it though.

—
Reply to this email directly or view it on GitHub.