Fix require and include call style

Shopify · Dec 14, 2023 · 070151f · 070151f
1 parent 1bc26d1
commit 070151f
Show file tree

Hide file tree

Showing 37 changed files with 91 additions and 90 deletions.
diff --git a/Rakefile b/Rakefile
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require("rake/extensiontask")
-require("bundler/gem_tasks")
+require "rake/extensiontask"
+require "bundler/gem_tasks"
 
 gemspec = Gem::Specification.load("bootsnap.gemspec")
 Rake::ExtensionTask.new do |ext|

diff --git a/bin/console b/bin/console
@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require("bundler/setup")
-require("bootsnap")
+require "bundler/setup"
+require "bootsnap"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -11,5 +11,5 @@ require("bootsnap")
 # require "pry"
 # Pry.start
 
-require("irb")
+require "irb"
 IRB.start(__FILE__)
diff --git a/bootsnap.gemspec b/bootsnap.gemspec
@@ -2,7 +2,7 @@
 
 lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require("bootsnap/version")
+require "bootsnap/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "bootsnap"

diff --git a/ext/bootsnap/extconf.rb b/ext/bootsnap/extconf.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("mkmf")
+require "mkmf"
 
 if %w[ruby truffleruby].include?(RUBY_ENGINE)
   $CFLAGS << " -O3 "

diff --git a/lib/bootsnap.rb b/lib/bootsnap.rb
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require_relative("bootsnap/version")
-require_relative("bootsnap/bundler")
-require_relative("bootsnap/load_path_cache")
-require_relative("bootsnap/compile_cache")
+require_relative "bootsnap/version"
+require_relative "bootsnap/bundler"
+require_relative "bootsnap/load_path_cache"
+require_relative "bootsnap/compile_cache"
 
 module Bootsnap
   InvalidConfiguration = Class.new(StandardError)

diff --git a/lib/bootsnap/bundler.rb b/lib/bootsnap/bundler.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Bootsnap
-  extend(self)
+  extend self
 
   def bundler?
     return false unless defined?(::Bundler)

diff --git a/lib/bootsnap/compile_cache.rb b/lib/bootsnap/compile_cache.rb
@@ -12,7 +12,7 @@ def UNCOMPILABLE.inspect
     def self.setup(cache_dir:, iseq:, yaml:, json:, readonly: false)
       if iseq
         if supported?
-          require_relative("compile_cache/iseq")
+          require_relative "compile_cache/iseq"
           Bootsnap::CompileCache::ISeq.install!(cache_dir)
         elsif $VERBOSE
           warn("[bootsnap/setup] bytecode caching is not supported on this implementation of Ruby")
@@ -21,7 +21,7 @@ def self.setup(cache_dir:, iseq:, yaml:, json:, readonly: false)
 
       if yaml
         if supported?
-          require_relative("compile_cache/yaml")
+          require_relative "compile_cache/yaml"
           Bootsnap::CompileCache::YAML.install!(cache_dir)
         elsif $VERBOSE
           warn("[bootsnap/setup] YAML parsing caching is not supported on this implementation of Ruby")
@@ -30,7 +30,7 @@ def self.setup(cache_dir:, iseq:, yaml:, json:, readonly: false)
 
       if json
         if supported?
-          require_relative("compile_cache/json")
+          require_relative "compile_cache/json"
           Bootsnap::CompileCache::JSON.install!(cache_dir)
         elsif $VERBOSE
           warn("[bootsnap/setup] JSON parsing caching is not supported on this implementation of Ruby")

diff --git a/lib/bootsnap/compile_cache/iseq.rb b/lib/bootsnap/compile_cache/iseq.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require("bootsnap/bootsnap")
-require("zlib")
+require "bootsnap/bootsnap"
+require "zlib"
 
 module Bootsnap
   module CompileCache

diff --git a/lib/bootsnap/compile_cache/json.rb b/lib/bootsnap/compile_cache/json.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("bootsnap/bootsnap")
+require "bootsnap/bootsnap"
 
 module Bootsnap
   module CompileCache
@@ -46,8 +46,8 @@ def install!(cache_dir)
         end
 
         def init!
-          require("json")
-          require("msgpack")
+          require "json"
+          require "msgpack"
 
           self.msgpack_factory = MessagePack::Factory.new
           self.supported_options = [:symbolize_names]

diff --git a/lib/bootsnap/compile_cache/yaml.rb b/lib/bootsnap/compile_cache/yaml.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("bootsnap/bootsnap")
+require "bootsnap/bootsnap"
 
 module Bootsnap
   module CompileCache
@@ -55,9 +55,9 @@ def unpack(payload)
         end
 
         def init!
-          require("yaml")
-          require("msgpack")
-          require("date")
+          require "yaml"
+          require "msgpack"
+          require "date"
 
           @implementation = ::YAML::VERSION >= "4" ? Psych4 : Psych3
           if @implementation::Patch.method_defined?(:unsafe_load_file) && !::YAML.respond_to?(:unsafe_load_file)

diff --git a/lib/bootsnap/load_path_cache.rb b/lib/bootsnap/load_path_cache.rb
@@ -41,8 +41,8 @@ def setup(cache_path:, development_mode:, ignore_directories:, readonly: false)
         PathScanner.ignored_directories = ignore_directories if ignore_directories
         @load_path_cache = Cache.new(store, $LOAD_PATH, development_mode: development_mode)
         @enabled = true
-        require_relative("load_path_cache/core_ext/kernel_require")
-        require_relative("load_path_cache/core_ext/loaded_features")
+        require_relative "load_path_cache/core_ext/kernel_require"
+        require_relative "load_path_cache/core_ext/loaded_features"
       end
 
       def unload!
@@ -71,10 +71,10 @@ def supported?
 end
 
 if Bootsnap::LoadPathCache.supported?
-  require_relative("load_path_cache/path_scanner")
-  require_relative("load_path_cache/path")
-  require_relative("load_path_cache/cache")
-  require_relative("load_path_cache/store")
-  require_relative("load_path_cache/change_observer")
-  require_relative("load_path_cache/loaded_features_index")
+  require_relative "load_path_cache/path_scanner"
+  require_relative "load_path_cache/path"
+  require_relative "load_path_cache/cache"
+  require_relative "load_path_cache/store"
+  require_relative "load_path_cache/change_observer"
+  require_relative "load_path_cache/loaded_features_index"
 end
diff --git a/lib/bootsnap/load_path_cache/cache.rb b/lib/bootsnap/load_path_cache/cache.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative("../explicit_require")
+require_relative "../explicit_require"
 
 module Bootsnap
   module LoadPathCache

diff --git a/lib/bootsnap/load_path_cache/path.rb b/lib/bootsnap/load_path_cache/path.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative("path_scanner")
+require_relative "path_scanner"
 
 module Bootsnap
   module LoadPathCache

diff --git a/lib/bootsnap/load_path_cache/path_scanner.rb b/lib/bootsnap/load_path_cache/path_scanner.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative("../explicit_require")
+require_relative "../explicit_require"
 
 module Bootsnap
   module LoadPathCache

diff --git a/lib/bootsnap/load_path_cache/store.rb b/lib/bootsnap/load_path_cache/store.rb
@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require_relative("../explicit_require")
+require_relative "../explicit_require"
 
-Bootsnap::ExplicitRequire.with_gems("msgpack") { require("msgpack") }
+Bootsnap::ExplicitRequire.with_gems("msgpack") { require "msgpack" }
 
 module Bootsnap
   module LoadPathCache

diff --git a/lib/bootsnap/setup.rb b/lib/bootsnap/setup.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
-require_relative("../bootsnap")
+require_relative "../bootsnap"
 
 Bootsnap.default_setup
diff --git a/test/bundler_test.rb b/test/bundler_test.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 class BundlerTest < Minitest::Test
   def test_bundler_with_bundle_bin_path_env

diff --git a/test/cli_test.rb b/test/cli_test.rb
@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require("test_helper")
-require("bootsnap/cli")
+require "test_helper"
+require "bootsnap/cli"
 
 module Bootsnap
   class CLITest < Minitest::Test
-    include(TmpdirHelper)
+    include TmpdirHelper
 
     def setup
       super

diff --git a/test/compile_cache/iseq_cache_test.rb b/test/compile_cache/iseq_cache_test.rb
@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 class CompileCacheISeqTest < Minitest::Test
-  include(CompileCacheISeqHelper)
-  include(TmpdirHelper)
+  include CompileCacheISeqHelper
+  include TmpdirHelper
 
   def test_ruby_bug_18250
     Help.set_file("a.rb", "def foo(*); ->{ super }; end; def foo(**); ->{ super }; end", 100)

diff --git a/test/compile_cache/json_test.rb b/test/compile_cache/json_test.rb
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 class CompileCacheJSONTest < Minitest::Test
-  include(TmpdirHelper)
+  include TmpdirHelper
 
   module FakeJson
     Fallback = Class.new(StandardError)

diff --git a/test/compile_cache/yaml_test.rb b/test/compile_cache/yaml_test.rb
@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 class CompileCacheYAMLTest < Minitest::Test
-  include(TmpdirHelper)
+  include TmpdirHelper
 
   module FakeYaml
     Fallback = Class.new(StandardError)

diff --git a/test/compile_cache_handler_errors_test.rb b/test/compile_cache_handler_errors_test.rb
@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 class CompileCacheHandlerErrorsTest < Minitest::Test
-  include(CompileCacheISeqHelper)
-  include(TmpdirHelper)
+  include CompileCacheISeqHelper
+  include TmpdirHelper
 
   # now test three failure modes of each handler method:
   #   1. unexpected type

diff --git a/test/compile_cache_key_format_test.rb b/test/compile_cache_key_format_test.rb
@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
-require("test_helper")
-require("tempfile")
-require("tmpdir")
-require("fileutils")
+require "test_helper"
+require "tempfile"
+require "tmpdir"
+require "fileutils"
 
 class CompileCacheKeyFormatTest < Minitest::Test
   FILE = File.expand_path(__FILE__)
-  include(CompileCacheISeqHelper)
-  include(TmpdirHelper)
+  include CompileCacheISeqHelper
+  include TmpdirHelper
 
   R = {
     version: 0...4,

diff --git a/test/compile_cache_test.rb b/test/compile_cache_test.rb
@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 class CompileCacheTest < Minitest::Test
-  include(CompileCacheISeqHelper)
-  include(TmpdirHelper)
+  include CompileCacheISeqHelper
+  include TmpdirHelper
 
   def teardown
     super
@@ -21,7 +21,7 @@ def test_compile_option_crc32
 
   def test_coverage_running?
     refute(Bootsnap::CompileCache::Native.coverage_running?)
-    require("coverage")
+    require "coverage"
     begin
       Coverage.start
       assert(Bootsnap::CompileCache::Native.coverage_running?)

diff --git a/test/helper_test.rb b/test/helper_test.rb
@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 class HelperTest < Minitest::Test
-  include(CompileCacheISeqHelper)
-  include(TmpdirHelper)
+  include CompileCacheISeqHelper
+  include TmpdirHelper
 
   def test_validate_cache_path
     path = Help.set_file("a.rb", "a = a = 3", 100)

diff --git a/test/integration/kernel_test.rb b/test/integration/kernel_test.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 module Bootsnap
   class KernelTest < Minitest::Test

diff --git a/test/load_path_cache/cache_test.rb b/test/load_path_cache/cache_test.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 module Bootsnap
   module LoadPathCache

diff --git a/test/load_path_cache/change_observer_test.rb b/test/load_path_cache/change_observer_test.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 module Bootsnap
   module LoadPathCache

diff --git a/test/load_path_cache/core_ext/kernel_require_test.rb b/test/load_path_cache/core_ext/kernel_require_test.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 module Bootsnap
   class KernelRequireTest < Minitest::Test

diff --git a/test/load_path_cache/loaded_features_index_test.rb b/test/load_path_cache/loaded_features_index_test.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 module Bootsnap
   module LoadPathCache

diff --git a/test/load_path_cache/path_scanner_test.rb b/test/load_path_cache/path_scanner_test.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require("test_helper")
+require "test_helper"
 
 module Bootsnap
   module LoadPathCache