Bind rb_get_path to better respect Kernel#require duck-type
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
rb-get-path
branch
3 times, most recently
from
c160dab
to
d24e614
Compare
Kernel#require turns its argument into a path by calling `to_path` if it responds to it, and then into a String (the argument or the return value of `to_path`) by using implicit conversion (`to_str`). Co-authored-by: Étienne Barrié <etienne.barrie@gmail.com>
casperisfine
force-pushed
the
rb-get-path
branch
from
d24e614
to
671d1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #396
Rather than to do intricate things to replicate
rb_get_path, we can bind it from our native extension.We retain the ruby implementation for bootstrap and for implementations on which we don't have an extension.