Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare Redis >= 5.0 dependency #246

Closed
wants to merge 1 commit into from

Conversation

pedropb
Copy link

@pedropb pedropb commented Jan 3, 2024

Since b403d0c, Redis >= 5 has been a dependency for ci-queue. This commit declares this dependency on the gemspec file.

Relates to #156 .


We ran into this issue while troubleshooting a failed dependabot bump on ci-queue. The transitive dependency on redis resolved to version 4.8.1 in our app, which satisfied all gems except ci-queue.

Since b403d0c, Redis >= 5 has been a
dependency for ci-queue. This commit declares this dependency on the
gemspec file.
Copy link
Contributor

@ChrisBr ChrisBr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Waiting for @casperisfine final approval who is on holiday atm.

@ChrisBr
Copy link
Contributor

ChrisBr commented Jan 4, 2024

Alternatively we could do something like to not enforce the Redis version.

if ::Redis::VERSION < "5.0.0"
  @redis = ::Redis.new(
    url: redis_url,
    # Booting a CI worker is costly, so in case of a Redis blip,
    # it makes sense to retry for a while before giving up.
    reconnect_attempts: [0, 0, 0.1, 0.5, 1, 3, 5],
  )
else
  @redis = ::Redis.new(url: redis_url)
end

@ChrisBr ChrisBr mentioned this pull request Jan 4, 2024
@ChrisBr
Copy link
Contributor

ChrisBr commented Jan 4, 2024

Fixed in #248

@ChrisBr
Copy link
Contributor

ChrisBr commented Jan 4, 2024

I released v0.41.0. Let me know if that works.

Thanks for reporting ❤️

@ChrisBr ChrisBr closed this Jan 4, 2024
@pedropb
Copy link
Author

pedropb commented Jan 4, 2024

Upgrading straight to 0.41.0 worked for us @ChrisBr . Thanks for the swift response!

@pedropb pedropb deleted the pb/gemspec-redis-50-dependency branch January 4, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants