Implement minitest-queue bisect #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
bisect
branch
9 times, most recently
from
c370ba4 to
eaa39f8
Compare
wvanbergen
reviewed
Nov 27, 2017
| @@ -58,7 +58,8 @@ def queue=(queue) | |||
|
|
|||
| def queue_reporters=(reporters) | |||
| @queue_reporters ||= [] | |||
| Reporters.reporters = ((Reporters.reporters || []) - @queue_reporters) + reporters | |||
| Reporters.use!(((Reporters.reporters || []) - @queue_reporters) + reporters) | |||
| Minitest.backtrace_filter.add_filter(%r{exe/minitest-queue|lib/ci/queue/}) | |||
There was a problem hiding this comment.
This may only work in Rails environments. The minitest backtrace_filter object is not as advanced as the Rails one. Not sure if that's a problem.
There was a problem hiding this comment.
No it just need minitest-reporters (which is a ci-queue dependency). The integration test (not Rails) goes through this and it works just fine.
wvanbergen
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extract and properly package the
bisect-leakscript we've been using at Shopify.Usage:
minitest-queue --queue path/to/test_order.log --failing-test 'Test#identifier' bisect -Itest path/to/*_test.rb.See
minitest_bisect_test.rbfor more detailed usage, and output.