Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StdoutRouter for ruby 2.5 #27

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Fix StdoutRouter for ruby 2.5 #27

merged 1 commit into from
Apr 9, 2018

Conversation

lugray
Copy link
Contributor

@lugray lugray commented Apr 9, 2018

Ruby 2.5 changed IO#write from write(string) to write(string, ...). Before 2.5, puts "Hello" would call write("Hello"); write("\n"). It now calls write("Hello", "\n").

Ruby 2.5 changed `IO#write` from `write(string)` to
`write(string, ...)`.  Before 2.5, `puts "Hello"` would call
`write("Hello"); write("\n")`.  It now calls `write("Hello", "\n")`.
@lugray lugray requested review from burke and jules2689 April 9, 2018 17:14
str = str.force_encoding(Encoding::UTF_8)
apply_line_prefix(str, CLI::UI::Frame.prefix)
else
@pending_newline = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be only for the last arg? or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, each.

Copy link
Member

@burke burke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lugray lugray merged commit 67b8679 into master Apr 9, 2018
@lugray lugray deployed to production April 9, 2018 17:24 Active
@lugray lugray deleted the work_with_ruby_2.5 branch October 4, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants