Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chevron glyph, to be used for debug output #31

Merged
merged 1 commit into from
May 16, 2018
Merged

Add chevron glyph, to be used for debug output #31

merged 1 commit into from
May 16, 2018

Conversation

lavoiesl
Copy link
Contributor

Added a test and tested with a puts that it prints to my terminal (iTerm2 + tmux + zsh)

image

@lavoiesl lavoiesl requested a review from a team May 16, 2018 17:53
@thegedge
Copy link

thegedge commented May 16, 2018 •
edited
Loading

Some other options for debug, if we wanted a little more emoji in our lives:

🔎
right-pointing magnifying glass
Unicode: U+1F50E, UTF-8: F0 9F 94 8E

▶️
right-pointing triangle
Unicode: U+25B6 U+FE0F, UTF-8: E2 96 B6 EF B8 8F

📝
memo
Unicode: U+1F4DD, UTF-8: F0 9F 93 9D

I do like », since I would assume lots of debug output and all that emoji could be super distracting.

@lavoiesl
Copy link
Contributor Author

lavoiesl commented May 16, 2018 •
edited
Loading

Memo is kinda nice, but I do like the somber aspect of » for the same reason you mentioned

thegedge
thegedge approved these changes May 16, 2018
View reviewed changes
Copy link

@thegedge thegedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if anyone else has opinions, but 💪

@lavoiesl
Copy link
Contributor Author

We can always add others later.

@lavoiesl lavoiesl merged commit 245cce6 into master May 16, 2018
@lavoiesl lavoiesl deleted the seb/glyph-chevron branch May 16, 2018 18:46
@lugray lugray temporarily deployed to production November 9, 2018 18:39 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegedge thegedge thegedge approved these changes

@burke burke burke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lavoiesl @thegedge @burke @lugray