Fix ansi problem #42
Merged
Fix ansi problem #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burke
reviewed
Oct 12, 2018
| # Move to the end of the line | ||
| # | ||
| def self.end_of_line | ||
| control("\033[", 'C') |
There was a problem hiding this comment.
FWIW \033[9999C seems to do the trick.
burke
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI::UI::ANSI.end_of_linewas broken in a couple of ways. First, it didn't actually move to the end of the line, it advanced the cursor by one place. Second, it was printing an extra escape sequence opener to do so (\e[\e[Cinstead of\e[C). Some terminals were ignoring this invalid output, but others showed a character for it.Given it wasn't doing the job it advertised, and that I could not find a trivial sequence that would, and where it was being used it clearly wasn't needed since it wasn't doing the job we thought it was, I removed it, and adjusted the places where it was being used.
Fixes #39.