update tests related to store selection prompt

Shopify · Aug 1, 2024 · 220ce1a · 220ce1a
1 parent 8ae9677
commit 220ce1a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 12 deletions.
diff --git a/packages/app/src/cli/prompts/dev.test.ts b/packages/app/src/cli/prompts/dev.test.ts
@@ -135,13 +135,13 @@ describe('selectApp', () => {
 })
 
 describe('selectStore', () => {
-  const defaultClientName = 'partners'
+  const defaultShowDomainOnPrompt = false
   test('returns undefined if store list is empty', async () => {
     // Given
     const stores: OrganizationStore[] = []
 
     // When
-    const got = await selectStorePrompt(stores, defaultClientName)
+    const got = await selectStorePrompt(stores, defaultShowDomainOnPrompt)
 
     // Then
     expect(got).toEqual(undefined)
@@ -154,7 +154,7 @@ describe('selectStore', () => {
     const outputMock = mockAndCaptureOutput()
 
     // When
-    const got = await selectStorePrompt(stores, defaultClientName)
+    const got = await selectStorePrompt(stores, defaultShowDomainOnPrompt)
 
     // Then
     expect(got).toEqual(STORE1)
@@ -168,7 +168,7 @@ describe('selectStore', () => {
     vi.mocked(renderAutocompletePrompt).mockResolvedValue('2')
 
     // When
-    const got = await selectStorePrompt(stores, defaultClientName)
+    const got = await selectStorePrompt(stores, defaultShowDomainOnPrompt)
 
     // Then
     expect(got).toEqual(STORE2)
@@ -181,14 +181,13 @@ describe('selectStore', () => {
     })
   })
 
-  test('renders stores list with domain if client is app-management ', async () => {
+  test('renders stores list with domain if showDomainOnPrompt is true ', async () => {
     // Given
-    const clientName = 'app-management'
     const stores: OrganizationStore[] = [STORE1, STORE2]
     vi.mocked(renderAutocompletePrompt).mockResolvedValue('2')
 
     // When
-    const got = await selectStorePrompt(stores, clientName)
+    const got = await selectStorePrompt(stores, true)
 
     // Then
     expect(got).toEqual(STORE2)

diff --git a/packages/app/src/cli/services/dev/select-store.test.ts b/packages/app/src/cli/services/dev/select-store.test.ts
@@ -6,6 +6,7 @@ import {
   confirmConversionToTransferDisabledStorePrompt,
 } from '../../prompts/dev.js'
 import {testDeveloperPlatformClient} from '../../models/app/app.test-data.js'
+import {ClientName} from '../../utilities/developer-platform-client.js'
 import {beforeEach, describe, expect, vi, test} from 'vitest'
 import {isSpinEnvironment} from '@shopify/cli-kit/node/context/spin'
 import {firstPartyDev} from '@shopify/cli-kit/node/context/local'
@@ -47,6 +48,8 @@ const STORE3: OrganizationStore = {
   convertableToPartnerTest: false,
 }
 
+const defaultShowDomainOnPrompt = false
+
 beforeEach(() => {
   vi.mocked(isSpinEnvironment).mockReturnValue(false)
 })
@@ -61,7 +64,20 @@ describe('selectStore', async () => {
 
     // Then
     expect(got).toEqual(STORE1)
-    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2])
+    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2], defaultShowDomainOnPrompt)
+  })
+
+  test('selectStorePrompt is called with showDomainOnPrompt = true if clientName is app-management', async () => {
+    // Given
+    vi.mocked(selectStorePrompt).mockResolvedValueOnce(STORE1)
+    const developerPlatformClient = testDeveloperPlatformClient({clientName: ClientName.AppManagement})
+
+    // When
+    const got = await selectStore([STORE1, STORE2], ORG1, developerPlatformClient)
+
+    // Then
+    expect(got).toEqual(STORE1)
+    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2], true)
   })
 
   test('prompts user to convert store to non-transferable if selection is invalid', async () => {
@@ -74,7 +90,7 @@ describe('selectStore', async () => {
 
     // Then
     expect(got).toEqual(STORE2)
-    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2])
+    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2], defaultShowDomainOnPrompt)
     expect(confirmConversionToTransferDisabledStorePrompt).toHaveBeenCalled()
   })
 
@@ -89,7 +105,7 @@ describe('selectStore', async () => {
 
     // Then
     expect(got).toEqual(STORE1)
-    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2])
+    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2], defaultShowDomainOnPrompt)
     expect(confirmConversionToTransferDisabledStorePrompt).toHaveBeenCalled()
   })
 
@@ -106,7 +122,7 @@ describe('selectStore', async () => {
     // Then
     expect(got).toEqual(STORE2)
     expect(developerPlatformClient.convertToTransferDisabledStore).not.toHaveBeenCalled()
-    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2])
+    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2], defaultShowDomainOnPrompt)
   })
 
   test('throws if store is non convertible', async () => {
@@ -130,7 +146,7 @@ describe('selectStore', async () => {
 
     // Then
     await expect(got).rejects.toThrowError()
-    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2])
+    expect(selectStorePrompt).toHaveBeenCalledWith([STORE1, STORE2], defaultShowDomainOnPrompt)
   })
 
   test('prompts user to create & reload, fetches 10 times and tries again if reload is true', async () => {