Set asset stats when writing file to theme-fs

Shopify · Sep 18, 2024 · 60f895a · 60f895a
1 parent 1dce161
commit 60f895a
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/packages/theme/src/cli/utilities/theme-fs.test.ts b/packages/theme/src/cli/utilities/theme-fs.test.ts
@@ -181,6 +181,8 @@ describe('theme-fs', () => {
         key: 'assets/new_file.css',
         checksum: '1010',
         value: 'content',
+        stats: {size: 7, mtime: expect.any(Number)},
+        attachment: '',
       })
     })
 
@@ -203,6 +205,8 @@ describe('theme-fs', () => {
         key: 'assets/new_image.gif',
         checksum: '1010',
         attachment,
+        value: '',
+        stats: {size: 6, mtime: expect.any(Number)},
       })
     })
 
@@ -216,7 +220,13 @@ describe('theme-fs', () => {
 
       let filesUpdated = false
       vi.mocked(writeFile).mockImplementationOnce(() => {
-        filesUpdated = themeFileSystem.files.get(newAsset.key) === newAsset
+        expect(themeFileSystem.files.get(newAsset.key)).toEqual({
+          ...newAsset,
+          attachment: '',
+          stats: {size: 7, mtime: expect.any(Number)},
+        })
+        filesUpdated = true
+
         return Promise.resolve()
       })
 

diff --git a/packages/theme/src/cli/utilities/theme-fs.ts b/packages/theme/src/cli/utilities/theme-fs.ts
@@ -219,7 +219,15 @@ export function mountThemeFileSystem(root: string, options?: ThemeFileSystemOpti
       await removeThemeFile(root, fileKey)
     },
     write: async (asset: ThemeAsset) => {
-      files.set(asset.key, asset)
+      files.set(
+        asset.key,
+        buildThemeAsset({
+          key: asset.key,
+          checksum: asset.checksum,
+          value: asset.value ?? '',
+          attachment: asset.attachment ?? '',
+        }),
+      )
       await writeThemeFile(root, asset)
     },
     read,