Merge pull request #3675 from Shopify/theme-access

Introduce support to Theme Access app in the new `shopify theme push` implementation
Shopify · Apr 12, 2024 · 6d2173f · 6d2173f
2 parents 1d02f09 + e32854a
commit 6d2173f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/.changeset/lazy-maps-retire.md b/.changeset/lazy-maps-retire.md
@@ -0,0 +1,5 @@
+---
+'@shopify/theme': patch
+---
+
+Activate the new implementation of `shopify theme push` in CI/CD workflows to support contextual assets
diff --git a/packages/theme/src/cli/commands/theme/push.test.ts b/packages/theme/src/cli/commands/theme/push.test.ts
@@ -98,17 +98,6 @@ describe('Push', () => {
   })
 
   describe('run with CLI 2 implementation', () => {
-    test('should run the CLI 2 implementation if the password flag is provided', async () => {
-      // Given
-      const theme = buildTheme({id: 1, name: 'Theme', role: 'development'})!
-
-      // When
-      await runPushCommand(['--password', '123'], path, adminSession, theme)
-
-      // Then
-      expectCLI2ToHaveBeenCalledWith(`theme push ${path} --development-theme-id ${theme.id}`)
-    })
-
     test('should pass development theme from local storage to CLI 2', async () => {
       // Given
       const theme = buildTheme({id: 1, name: 'Theme', role: 'development'})!

diff --git a/packages/theme/src/cli/commands/theme/push.ts b/packages/theme/src/cli/commands/theme/push.ts
@@ -151,7 +151,7 @@ export default class Push extends ThemeCommand {
 
     const developmentThemeManager = new DevelopmentThemeManager(adminSession)
 
-    if (!flags.stable && !flags.password) {
+    if (!flags.stable) {
       const {live, development, unpublished, path, nodelete, theme, publish, json, force, ignore, only} = flags
 
       let selectedTheme: Theme