Merge pull request #4475 from Shopify/jm/fixpull

[Themes] Account for empty assets when calculating theme asset size
Shopify · Sep 19, 2024 · d71bca9 · d71bca9
2 parents 5cf4928 + 3756ce8
commit d71bca9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/nervous-sloths-wash.md b/.changeset/nervous-sloths-wash.md
@@ -0,0 +1,5 @@
+---
+'@shopify/cli-kit': patch
+---
+
+Fix a bug when building empty theme assets
diff --git a/packages/cli-kit/src/public/node/themes/factories.ts b/packages/cli-kit/src/public/node/themes/factories.ts
@@ -12,7 +12,8 @@ interface RemoteThemeResponse {
 interface RemoteAssetResponse {
  key: string
  checksum: string
- attachment: string
+ attachment: string | undefined
+ // value is an empty string ('') when the file is empty
  value: string
 }
 
@@ -52,8 +53,7 @@ export function buildThemeAsset(asset?: RemoteAssetResponse): ThemeAsset | undef
 
  const {key, checksum, attachment, value} = asset
  // Note: for attachments, this is the size of the base64 string, not the real length of the file
- const stats = {size: (value || attachment).length, mtime: Date.now()}
-
+ const stats = {size: (value || attachment || '').length, mtime: Date.now()}
  return {key, checksum, attachment, value, stats}
 }