Modify payload directly and add additional test

Shopify · Mar 29, 2024 · fd7f92a · fd7f92a
1 parent c3200bd
commit fd7f92a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/cli-kit/src/public/node/monorail.test.ts b/packages/cli-kit/src/public/node/monorail.test.ts
@@ -46,5 +46,6 @@ describe('monorail', () => {
  const res = await publishMonorailEvent('fake_schema/0.0', {api_key: 'some-api-key'}, {baz: 'abc'})
  expect(res.type).toEqual('ok')
  expect(outputMock.debug()).toContain('"api_key": "****"')
+ expect(outputMock.debug()).not.toContain('some-api-key')
  })
 })
diff --git a/packages/cli-kit/src/public/node/monorail.ts b/packages/cli-kit/src/public/node/monorail.ts
@@ -222,12 +222,11 @@ export async function publishMonorailEvent<TSchemaId extends keyof Schemas, TPay
  * @returns The payload with the api_key sanitized.
  */
 function sanitizePayload<T extends object>(payload: T): T {
- const result = {...payload}
- if ('api_key' in result) {
- result.api_key = '****'
+ if ('api_key' in payload) {
+ payload.api_key = '****'
  }
 
- return result
+ return payload
 }
 
 const buildHeaders = (currentTime: number) => {