Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Upgrade theme checker #1049

Closed
2 tasks done
bakura10 opened this issue Jan 10, 2023 · 5 comments · Fixed by #1064
Closed
2 tasks done

[Bug]: Upgrade theme checker #1049

bakura10 opened this issue Jan 10, 2023 · 5 comments · Fixed by #1064
Labels
Type: Bug Something isn't working

Comments

@bakura10
Copy link

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Currently, the CLI uses the version 1.12.1 for the theme check (

const ThemeCheckVersion = '1.12.1'
).

The version 1.13 added support for the new "section group". The CLI should be updated as well.

Thanks :)

Actual behavior

Shopify CLI uses an older version.

Stack trace

No response

Reproduction steps

Operating System

OS X

Shopify CLI version (check your project's package.json if you're not sure)

3.32

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

@bakura10 bakura10 added the Type: Bug Something isn't working label Jan 10, 2023
@katiewelton
Copy link

Is there no way to update theme check separately? This is beyond frustrating

@dazjohnsoncc
Copy link

Yep, this is blocking us also.

@bakura10
Copy link
Author

Hi @veken1199

Unfrotunately, the issue has not been fixed for some reason. I have upgraded to the new Shopify CLI, but the theme checker still fails:

image

So either theme-check or Shopify CLI has a bug here :)

@dazjohnsoncc
Copy link

Can confirm, same issue for me running 3.32.1. I also get a lovely big stack trace:
image

@alvaro-shopify
Copy link
Contributor

Hi @bakura10 @dazjohnsoncc ! We have released CLI 3.33.0 to fix this problem. Please, update your version when possible. Let me know if now it's working for you. Sorry for inconveniences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants