Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump theme-check to 1.14.0 #1064

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Bump theme-check to 1.14.0 #1064

merged 1 commit into from
Jan 11, 2023

Conversation

veken1199
Copy link
Contributor

@veken1199 veken1199 commented Jan 11, 2023

WHY are these changes introduced?

Bumping theme-check version to support section groups

FIXES #1049

WHAT is this pull request doing?

updating theme-check version to the new release

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
68.84% (+0.03% 🔼)
3670/5331
🟡 Branches
65.09% (-0.05% 🔻)
1544/2372
🟡 Functions
67.07% (+0.02% 🔼)
935/1394
🟡 Lines
69.68% (+0.05% 🔼)
3496/5017
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / string.ts
71.43% 100% 57.14% 70.83%
🟢
... / template.ts
91.67% 62.5% 100% 91.67%
🟢 cli-kit/src/toml.ts 100% 100% 100% 100%
🔴
... / vscode.ts
40% 28.57% 50% 40%

Test suite run success

919 tests passing in 474 suites.

Report generated by 🧪jest coverage report action from 39315c3

@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023

Benchmark report

The following table contains a summary of the startup time for all commands.

Status Command Baseline Current Diff
🟢 app build 2200 ms 2349 ms 6.77 %
🟢 app deploy 2128 ms 2156 ms 1.32 %
🟢 app dev 3005 ms 3150 ms 4.83 %
🔴 app env pull 2185 ms 2429 ms 11.17 %
🟢 app env show 2971 ms 3064 ms 3.13 %
🟢 app generate extension 2266 ms 2016 ms -11.03 %
🔴 app generate schema 2067 ms 2867 ms 38.7 %
🔴 app info 1969 ms 2584 ms 31.23 %
🟢 app scaffold extension 2608 ms 2120 ms -18.71 %
🔴 app update-url 1880 ms 2147 ms 14.2 %
🔴 theme check 2017 ms 2704 ms 34.06 %
🟢 theme delete 2271 ms 1944 ms -14.4 %
🟢 theme dev 2405 ms 1965 ms -18.3 %
🔴 theme help-old 1896 ms 2598 ms 37.03 %
🟢 theme info 2194 ms 2031 ms -7.43 %
🔴 theme init 1998 ms 2719 ms 36.09 %
🟢 theme language-server 1981 ms 2088 ms 5.4 %
🟢 theme list 2574 ms 1922 ms -25.33 %
🔴 theme open 1904 ms 2711 ms 42.38 %
🟢 theme package 1838 ms 1951 ms 6.15 %
🔴 theme publish 2216 ms 2930 ms 32.22 %
🟢 theme pull 2005 ms 1956 ms -2.44 %
🟢 theme push 1935 ms 1962 ms 1.4 %
🔴 theme share 1943 ms 2673 ms 37.57 %
🔴 webhook trigger 1902 ms 2286 ms 20.19 %

@veken1199 veken1199 changed the title Bump theme-check to 1.13.0 Bump theme-check to 1.14.0 Jan 11, 2023
@veken1199 veken1199 self-assigned this Jan 11, 2023
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @veken1199 🚀

@veken1199 veken1199 merged commit 784e27c into main Jan 11, 2023
@veken1199 veken1199 deleted the bump-theme-check branch January 11, 2023 15:57
@shopify-shipit shopify-shipit bot temporarily deployed to production January 11, 2023 16:30 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to nightly January 11, 2023 19:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Upgrade theme checker
4 participants